junlincc commented on pull request #15650:
URL: https://github.com/apache/superset/pull/15650#issuecomment-878792440


   LGTM! thanks for the quick fix! did spot a UX issue not caused by this PR, 
will file separately 
   @rosemarie-chiu wanna give a product/QA sign-off checkmark? 😉
   
   After 
   
   
https://user-images.githubusercontent.com/67837651/125395984-bfd98000-e360-11eb-9ee0-2111f58a673f.mov
   
   Before(unnecessary long video please skip watching lol )
   
   
https://user-images.githubusercontent.com/67837651/125396027-cbc54200-e360-11eb-9788-ee2231dde026.mov
   
   
https://user-images.githubusercontent.com/67837651/125396057-d7186d80-e360-11eb-8360-d7b2df693405.mov
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to