michael-s-molina commented on pull request #15661: URL: https://github.com/apache/superset/pull/15661#issuecomment-879165476
This will break the filter bar height in some scenarios: - Introduce a scroll when it's not required - Mess with the filter bar height calculation when scrolling https://user-images.githubusercontent.com/70410625/125475424-5bcb7664-2b0e-4fb4-80e3-d47b139c2577.mp4 The key to fix this is to consider the full-screen state in the `offset` variable: <img width="702" alt="Screen Shot 2021-07-13 at 11 57 00 AM" src="https://user-images.githubusercontent.com/70410625/125475025-237898e5-d510-4f1d-9740-ff2f9b5c53a3.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70410625/125475025-237898e5-d510-4f1d-9740-ff2f9b5c53a3.png"](https://user-images.githubusercontent.com/70410625/125475025-237898e5-d510-4f1d-9740-ff2f9b5c53a3.png"){kind=link}