suddjian commented on a change in pull request #15647:
URL: https://github.com/apache/superset/pull/15647#discussion_r669122841



##########
File path: superset-frontend/src/components/IconButton/index.tsx
##########
@@ -41,6 +41,15 @@ const StyledImage = styled.div`
   height: ${({ theme }) => theme.gridUnit * 18}px;
   margin: ${({ theme }) => theme.gridUnit * 3}px 0;
 
+  .default-db-icon {
+    font-size: ${({ theme }) => theme.gridUnit * 9}px;

Review comment:
       Looks like we don't have a typography size large enough for what you're 
going for here though. Doing math with the typography sizes sounds pretty 
unsavory. If we don't want to add an `xxxl` size maybe grid units are actually 
the right fit here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to