cccs-RyanS commented on a change in pull request #15154:
URL: https://github.com/apache/superset/pull/15154#discussion_r670426448
##########
File path: superset/connectors/base/models.py
##########
@@ -533,6 +533,7 @@ class BaseColumn(AuditMixinNullable, ImportExportMixin):
verbose_name = Column(String(1024))
is_active = Column(Boolean, default=True)
type = Column(String(32))
+ business_type = Column(String(255))
Review comment:
Hey so my org had discussed this with Ville Brofeldt and I was waiting
on some feedback (which is why its still a draft with very little context, my
apologies). The idea was to have business types on top of the db types to have
added flexibility. Let me speak to my coworker and I can get you a bunch of
extra context and I will add more context to the PR. Thanks for taking a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
