geido opened a new pull request #15709: URL: https://github.com/apache/superset/pull/15709
### SUMMARY It removes the `edit` param from the URL when discarding the changes of a newly created dashboard in order to exist the edit mode. Fixes #15673 ### BEFORE https://user-images.githubusercontent.com/60598000/125814297-5638f4ee-b2a7-4550-8c93-b8652bb2be9d.mov ### AFTER https://user-images.githubusercontent.com/60598000/125814640-e1812885-3988-4ff2-b720-854dcea460af.mp4 ### TESTING INSTRUCTIONS 1. Click on the global + button and create a new dashboard or click on the + dashboard from dashboard page list 2. Do not add anything to the new dashboard and click on 'DISCARD CHANGE' in dashboard edit mode 3. Observe the behavior ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #15673 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
