[GitHub] [superset] etr2460 opened a new pull request #15721: fix: Reduce js bundle size

Thu, 15 Jul 2021 13:57:21 -0700 


etr2460 opened a new pull request #15721:
URL: https://github.com/apache/superset/pull/15721


   ### SUMMARY
   This PR:
   - replaces react-icons with @react-icons/all-files in superset-ui packages 
to enable treeshaking of the unused icons
   - removes react-icons from Superset proper
   
   As an example, spa.js goes from 7.62MB to 6.42MB 
   
   Note that this pulls in some other changes from superset-ui, @kgabryje could 
you verify that these are fine to merge too? Thanks!
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before bundle size and existence of react-icons:
   <img width="951" alt="Screen Shot 2021-07-15 at 5 13 57 PM" 
src="https://user-images.githubusercontent.com/7409244/125855668-1f5d3c0c-3543-4884-b0bc-3ccc44d61c9b.png";>
   <img width="624" alt="Screen Shot 2021-07-15 at 7 29 15 PM" 
src="https://user-images.githubusercontent.com/7409244/125855683-3d48732d-c642-4a6e-9f55-ed28b86c3f59.png";>
   
   after:
   <img width="961" alt="Screen Shot 2021-07-15 at 10 46 57 PM" 
src="https://user-images.githubusercontent.com/7409244/125855728-b98fa131-3986-4ab8-8097-1d2289d8069b.png";>
   <img width="519" alt="Screen Shot 2021-07-15 at 10 44 19 PM" 
src="https://user-images.githubusercontent.com/7409244/125855734-2357bb90-b221-4f8e-942c-edbdff8df512.png";>
   
   ### TESTING INSTRUCTIONS
   CI, load a dashboard with a table and ensure the icons render
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @ktmud @graceguo-supercat @kgabryje 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to