kgabryje opened a new pull request #15731: URL: https://github.com/apache/superset/pull/15731
### SUMMARY Due to incorrect handling of `multi: false` prop in `DndColumnSelect`, we sometimes passed an array of arrays of column names, when the chart was expecting an array of column names. Moreover, I noticed that sometimes when we create a chart and then change dataset, chart still tries to use some column names from the old dataset. This PR fixes both issues. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: see https://github.com/apache/superset/issues/15532 ### TESTING INSTRUCTIONS 0. Set `ENABLE_EXPLORE_DRAG_AND_DROP` to True 1. Create a chart that uses controls that accept only single column, e.g. Chord 2. Verify that chart is created correctly 3. Change dataset and try to create a chart again 4. Verify that there are no "leftovers" from previous dataset (before, sometimes chart tried to use column names from previous dataset even though they were removed from controls) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: fixes #15532 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
