kgabryje opened a new pull request #15740: URL: https://github.com/apache/superset/pull/15740
### SUMMARY Implements UX improvements for DnD, some of which are prerequisites for drag and dropping time columns. Changes include: - sorting columns in dataset panel so that temporal columns are displayed first (so that it's easy find them and drag to time column control) - making delete button in `DndColumnSelect` configurable - we don't display the delete button for time column control - changed logic of `canDrop` on single selection controls. Before in order to change the selection, user had to remove current selection and drop a new column/metric. Now when control field has a value, user can just drop a new value and it will get swapped ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/125949640-faa0f395-91dd-4cc2-baec-822ac48bbe8d.mov ### TESTING INSTRUCTIONS Instructions for changes related to time column dnd will be described in a PR in superset-ui To test the new behaviour of single select controls: 0. Set `ENABLE_EXPLORE_DRAG_AND_DROP` to True 1. Open a chart that has controls that accept only a single value, e.g. Chord chart. 2. Add values to control fields, then swap them without removing first ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
