stephenLYZ commented on a change in pull request #15734:
URL: https://github.com/apache/superset/pull/15734#discussion_r671270942
##########
File path:
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -220,6 +224,11 @@ const DetailsEmpty = (theme: SupersetTheme) => css`
// overflow hidden on the details pane and overflow auto on the description
// (plus grid layout) enables the description to scroll while the header stays
in place.
+const TagsWrapper = styled.div`
+ grid-area: viz-tags;
+ width: ${({ theme }) => theme.gridUnit * 120}px;
+ padding-right: ${({ theme }) => theme.gridUnit * 14}px;
+`;
Review comment:
add: padding-bottom: ${({ theme }) => theme.gridUnit * 2}px;
##########
File path:
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -220,6 +224,11 @@ const DetailsEmpty = (theme: SupersetTheme) => css`
// overflow hidden on the details pane and overflow auto on the description
// (plus grid layout) enables the description to scroll while the header stays
in place.
+const TagsWrapper = styled.div`
+ grid-area: viz-tags;
+ width: ${({ theme }) => theme.gridUnit * 120}px;
+ padding-right: ${({ theme }) => theme.gridUnit * 14}px;
+`;
Review comment:
Add: padding-bottom: ${({ theme }) => theme.gridUnit * 2}px;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
