betodealmeida commented on a change in pull request #15719:
URL: https://github.com/apache/superset/pull/15719#discussion_r671402813
##########
File path: scripts/benchmark_migration.py
##########
@@ -177,18 +178,23 @@ def main(
for model in models:
missing = min_entities - model_rows[model]
if missing > 0:
+ entities: List[Model] = []
+ bar = ChargingBar("Processing", max=missing)
Review comment:
How does the print in 183 interact with the bar? I think it might be
better to reverse the order of 182,183.
Can you post a screencast of the progress bar in action? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
