eschutho opened a new pull request #15752:
URL: https://github.com/apache/superset/pull/15752


   This reverts commit 80b8df0673193e1a7ce1ec3c2c4c10c6b363097b.
   
   ### SUMMARY
   The commit above fixes cases for virtual datasets where an alias for a 
column was created with quotes for snowflake, but it does not work for regular 
datasets where the columns have not been aliased. Reverting this change for now 
because it is less likely to have a chart that relies on a dataset with a 
named, quoted aliases, than it it to be using an unquoted alias or a table. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   NA
   
   ### TESTING INSTRUCTIONS
   create a dataset or virtual dataset and try to create a chart from it
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to