john-bodley commented on a change in pull request #15580:
URL: https://github.com/apache/superset/pull/15580#discussion_r671608870
##########
File path: requirements/base.in
##########
@@ -18,3 +18,7 @@
-e file:.
pyrsistent>=0.16.1,<0.17
zipp==3.4.1
+click
+py>=1.10.0
+urllib3>=1.26.5
Review comment:
I'm not clear why this included here and not in `setup.py`. Also
[this](https://github.com/apache/superset/blob/9773aba522e957ed9423045ca153219638a85d2f/superset/db_engine_specs/clickhouse.py#L51)
non-top level import of `urllib3` seems weird.
##########
File path: requirements/base.in
##########
@@ -18,3 +18,7 @@
-e file:.
pyrsistent>=0.16.1,<0.17
zipp==3.4.1
+click
+py>=1.10.0
+urllib3>=1.26.5
+aiohttp>=3.7.4
Review comment:
Is this used anywhere? It's not evident per
[this](https://github.com/apache/superset/search?q=aiohttp) search.
##########
File path: requirements/base.in
##########
@@ -18,3 +18,7 @@
-e file:.
pyrsistent>=0.16.1,<0.17
zipp==3.4.1
+click
Review comment:
This is already defined in `setup.py`. It'll be pulled in via line #18.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
