geido opened a new pull request #15770: URL: https://github.com/apache/superset/pull/15770
### SUMMARY It removes an unnecessary `onChange` event that was blocking the Dataset editor from saving the changes to the data source successfully. Fixes #14592 ### BEFORE https://user-images.githubusercontent.com/60598000/126084699-de7a33d9-5deb-4936-8ed9-2d54c3421327.mp4 ### AFTER https://user-images.githubusercontent.com/60598000/126084703-aa166402-e2e3-4ea4-af76-946bad6f8f74.mp4 ### TESTING INSTRUCTIONS 1. Go to the Datasets page 2. Click the edit icon on an existing Physical dataset 3. In the Edit Dataset modal, click the lock icon to make changes to the dataset 4. Select a different database from the current database. Then select a schema/table 5. Save changes 6. Open the Edit Dataset modal again and make sure the changes have been saved successfully ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #14592 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
