etr2460 opened a new pull request #15786: URL: https://github.com/apache/superset/pull/15786
### SUMMARY Back in https://github.com/apache/superset/pull/8901 @villebro made changes to include `datasource.changed_on` to the chart cache key so that a change to the datasource would bust the chart cache. This was important because a user could change the sql for a datasource, but rerunning the chart wouldn't rerun the query before. In this PR it seems like we intended to also bust the cache when metrics/columns were changed (https://github.com/apache/superset/pull/8901/files#r372541748) but that doesn't seem to work. This PR addresses that oversight and adds a test to check it ### TESTING INSTRUCTIONS CI, new unit test create a chart, update a metric, see the chart's cache busted ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @john-bodley @villebro @dpgaspar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
