eschutho opened a new pull request #15790:
URL: https://github.com/apache/superset/pull/15790


   ### SUMMARY
   These changes add a new component for choosing timezones client side. It 
uses the timezone list from moment-timezone which has about 400 entries. To 
narrow that list for a UI dropdown, I have removed all duplicates (based on 
their standard and daylight timezone offsets). There is a map that makes some 
of these selections more readable; for example, "America/Los_Angeles" is a 
duplicate of Vancouver, so we map it to "Pacific Standard/Daylight Time". In a 
v2 I may see if there's a simple way to pull that name out of moment, but for 
now, there's a map of about 7-8 regions that seem to work. 
   There's a migration and some changes coming next that will implement this 
into reports. For now these changes should have no UI impact, and just 
introduce the component and storybook files. 
   
   I also bumped a few packages to keep this compatible with the addition of 
moment-timezone which required a bump in typescript, etc. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Example from storybook showing "UTC" being mapped to 
![TimezoneSelector_-_Interactive_Timezone_Selector_⋅_Storybook](https://user-images.githubusercontent.com/5186919/126240715-6d718848-d7a7-46e7-be5f-931a7c8fa0b7.png)
 GMT
   
   ### TESTING INSTRUCTIONS
   No visual changes in Superset yet, but you can test by running storybook
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to