[GitHub] [superset] lyndsiWilliams opened a new pull request #15793: feat: Begin incorporation of email report modal to Charts

Mon, 19 Jul 2021 21:47:38 -0700 


lyndsiWilliams opened a new pull request #15793:
URL: https://github.com/apache/superset/pull/15793


   ### SUMMARY
   This is the beginning of incorporation of the email report modal into Charts.
   
   ### SCREENSHOTS
   #### Chart entry point
   <img width="544" alt="Screen Shot 2021-07-19 at 11 27 36 PM" 
src="https://user-images.githubusercontent.com/55605634/126262894-3af7a33c-ed55-4d69-a5b9-9ed51150a2b5.png";>
   
   #### Report modal
   <img width="608" alt="Screen Shot 2021-07-19 at 11 31 48 PM" 
src="https://user-images.githubusercontent.com/55605634/126262917-ae3b355c-e703-4231-8b62-177195a0c1e3.png";>
   
   ### TESTING INSTRUCTIONS
   - Click "Charts" in the upper navigation bar
   - Navigate to any Chart
   - Click the Calendar icon button
        - Located at the top of the chart between the timer and the "Copy chart 
URL to clipboard" button
   - Observe the email report modal
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to