AAfghahi commented on a change in pull request #15785:
URL: https://github.com/apache/superset/pull/15785#discussion_r672640903
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -52,8 +58,7 @@ const propTypes = {
addSuccessToast: PropTypes.func.isRequired,
addDangerToast: PropTypes.func.isRequired,
addWarningToast: PropTypes.func.isRequired,
- userId: PropTypes.number,
- userEmail: PropTypes.string,
+ user: PropTypes.object,
Review comment:
Not yet, I can work on one, especially since we only need id, email, and
roles.
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -394,10 +451,10 @@ class Header extends React.PureComponent {
setRefreshFrequency,
lastModifiedTime,
} = this.props;
-
const userCanEdit = dashboardInfo.dash_edit_perm;
const userCanShare = dashboardInfo.dash_share_perm;
const userCanSaveAs = dashboardInfo.dash_save_perm;
+ const canAccesReportsModal = !editMode && this.canAddReportsModal();
Review comment:
that makes sense, I like that wording change.
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -52,8 +58,7 @@ const propTypes = {
addSuccessToast: PropTypes.func.isRequired,
addDangerToast: PropTypes.func.isRequired,
addWarningToast: PropTypes.func.isRequired,
- userId: PropTypes.number,
- userEmail: PropTypes.string,
+ user: PropTypes.object,
Review comment:
There is one already made, so I used it here:
https://github.com/apache/superset/pull/15780/files#diff-28dce1dca6d6af7337727e88763b10a356e37ac5a15bd731d05077e89e0a8298R43
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -52,8 +58,7 @@ const propTypes = {
addSuccessToast: PropTypes.func.isRequired,
addDangerToast: PropTypes.func.isRequired,
addWarningToast: PropTypes.func.isRequired,
- userId: PropTypes.number,
- userEmail: PropTypes.string,
+ user: PropTypes.object,
Review comment:
There is one already made, so I used it here:
https://github.com/apache/superset/pull/15780/files#diff-28dce1dca6d6af7337727e88763b10a356e37ac5a15bd731d05077e89e0a8298R43
but also, happy to hold off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
