kgabryje commented on a change in pull request #15798:
URL: https://github.com/apache/superset/pull/15798#discussion_r673154326
##########
File path:
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricPopoverTrigger.tsx
##########
@@ -76,6 +76,26 @@ class AdhocMetricPopoverTrigger extends React.PureComponent<
};
}
+ componentDidUpdate(
+ prevProps: Readonly<AdhocMetricPopoverTriggerProps>,
+ prevState: Readonly<AdhocMetricPopoverTriggerState>,
+ snapshot?: any,
+ ) {
Review comment:
Good point, I changed that. That required saving adhocMetric in state
though, so that I could compare previous and next in getDerviedStateFromProps.
Can you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
