suddjian commented on a change in pull request #15279:
URL: https://github.com/apache/superset/pull/15279#discussion_r673568413
##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -357,8 +359,10 @@ def rolling( # pylint: disable=too-many-arguments
rolling_type_options = rolling_type_options or {}
df_rolling = df[columns.keys()]
kwargs: Dict[str, Union[str, int]] = {}
- if not window:
+ if not window and window != 0:
Review comment:
I believe this is equivalent? Unless there is some python silliness I'm
not familiar with.
```suggestion
if window is None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
