betodealmeida commented on a change in pull request #15805:
URL: https://github.com/apache/superset/pull/15805#discussion_r673579120
##########
File path: superset/reports/commands/execute.py
##########
@@ -207,11 +209,10 @@ def _get_screenshot(self) -> bytes:
return image_data
def _get_csv_data(self) -> bytes:
- if self._report_schedule.chart:
- url = self._get_url(csv=True)
- auth_cookies =
machine_auth_provider_factory.instance.get_auth_cookies(
- self._get_user()
- )
Review comment:
`_get_csv_data` is only called for charts, so the if block is not
needed. And even if it where called for non-charts, the call to
`get_chart_csv_data` would fail, so I think it's safe to remove the block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
