betodealmeida commented on a change in pull request #15806:
URL: https://github.com/apache/superset/pull/15806#discussion_r674043283
##########
File path: setup.py
##########
@@ -111,6 +111,7 @@ def get_git_sha():
"sqlalchemy>=1.3.16, <1.4, !=1.3.21",
"sqlalchemy-utils>=0.36.6,<0.37",
"sqlparse==0.3.0", # PINNED! see
https://github.com/andialbrecht/sqlparse/issues/562
+ "tabulate==0.8.9",
Review comment:
@john-bodley I did run `pip-compile-multi --no-upgrade`, you can see
that `requirements/base.txt` was updated to include the dependency (it has no
additional dependencies of its own).
Also, my understanding is that it's better to pin the version for
dependencies with version `0.x`, since there's no guarantee that a minor
upgrade will maintain backwards compatibility (https://semver.org/#spec-item-4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
