john-bodley commented on a change in pull request #15757:
URL: https://github.com/apache/superset/pull/15757#discussion_r674140292
##########
File path: RELEASING/send_email.py
##########
@@ -61,7 +63,7 @@ def send_email(
server.sendmail(sender_email, receiver_email, message)
-def render_template(template_file: str, **kwargs) -> str:
+def render_template(template_file: str, **kwargs: Any) -> str:
Review comment:
@etr2460 it's more nuanced than that. `kwargs` are mostly represented as
`Any` elsewhere in the code base. I'll follow up with an additional PR which
makes a sweep of the entire repo.
Also the declared type is not of `kwargs` but rather `**kwargs` so instead
of `Dict[str, Any]` or `Dict[str, str]` say it should be the type of the value,
so `Any` and `str` respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
