geido edited a comment on pull request #15821: URL: https://github.com/apache/superset/pull/15821#issuecomment-884506986
P.S. I have closed the downloads in my browser which were occupying some space and I am seeing 5 items on my 15' laptop now. <img width="1067" alt="Screen Shot 2021-07-21 at 17 25 22" src="https://user-images.githubusercontent.com/60598000/126560726-7f2fe77a-1208-4858-9b22-b9aa52cf648c.png";> If we want to show more rows we might need to act also on the height of the datapanel itself as reducing the height of the cells does not give that much additional space. I would also like to point out that there are several other visual differences between the two tables. On the table chart, in every other row, the cells have a different background color. Also, the pagination is right positioned and comes in different colors compared to the table in the datapanel one. Finally, the table of the datapanel is used in other places too, such as the "Change dataset" modal. I left that one untouched as the issue did not specify to change it everywhere. If we are looking to make the tables look consistent (aka the same) everywhere, we have to change several other layout parts. CC @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/60598000/126560726-7f2fe77a-1208-4858-9b22-b9aa52cf648c.png"](https://user-images.githubusercontent.com/60598000/126560726-7f2fe77a-1208-4858-9b22-b9aa52cf648c.png"){kind=link}