geido opened a new pull request #15841: URL: https://github.com/apache/superset/pull/15841
### SUMMARY It removes the `getDerivedStateFromProps` introduced by PR #14493 that was causing the Collapse to behave inconsistently. The removal does not seem to affect the functionality for which the PR was made. @villebro your confirmation will be appreciated here. Fixes: #15829 ### BEFORE https://user-images.githubusercontent.com/60598000/126671260-2cd0c0ab-30aa-4e8c-8fcc-8c65a7b84c2f.mov ### AFTER https://user-images.githubusercontent.com/60598000/126671313-c8ea5078-1baf-4e89-b961-3281ccb6548c.mp4 ### TESTING INSTRUCTIONS 1. Open a chart in Explore 2. Go to the Customize tab and make sure it opens correctly 3. Change viz type 4. Go again to the Customize tab and make sure it opens correctly ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #15829 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
