suddjian commented on a change in pull request #15868:
URL: https://github.com/apache/superset/pull/15868#discussion_r675713200
##########
File path:
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -144,25 +159,30 @@ const RightPane = styled.div`
overflow-y: scroll;
`;
-const AllTagsWrapper = styled.div`
- ${({ theme }) => `
- grid-area: tags;
- margin: ${theme.gridUnit * 4}px ${theme.gridUnit * 2}px 0;
- input {
- font-size: ${theme.typography.sizes.s};
- }
- `}
-`;
-
-const CategoriesWrapper = styled.div`
+const Wrapper = styled.div`
Review comment:
`Wrapper` isn't a very descriptive name. I was going to suggest renaming
it so that it indicates what it is wrapping, but then I noticed that it lives
directly within the `LeftPane`. Is it possible to merge these styles into
`LeftPane` and remove the `Wrapper` component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
