john-bodley opened a new pull request #15874: URL: https://github.com/apache/superset/pull/15874
### SUMMARY I'm not sure why in https://github.com/apache/superset/pull/15482 we construct a new `SupersetError` (with corresponding message, error type, and level) rather than merely leveraging the mandatory `SupersetError` which raised as part of the `SupersetSecurityException`. These errors contain specifics (message, error type, etc.) which differ depending on the type of exception ([example](https://github.com/apache/superset/blob/master/superset/security/manager.py#L410-L418))—which also may be custom for security manager overrides—and thus should be preserved. This PR merely uses the previous `SupersetError` (which is guaranteed to exist per the [SupersetSecurityException](https://github.com/apache/superset/blob/02032ee8a478ab9578cf6e13a7645a8b4106be58/superset/exceptions.py#L130-L137) signature) rather than constructing a new error. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
