john-bodley opened a new pull request #15878:
URL: https://github.com/apache/superset/pull/15878


   ### SUMMARY
   
   Both the Hive and Presto live cursors have implicit async handling of cancel 
queries, however post https://github.com/apache/superset/pull/15403 when you 
stop a query in SQL Lab it incorrectly mentioned that the query could not be 
stopped and thus prevented to user from iterating within the SQL editor.
   
   This PR adds a new method to check if the database implicitly handles the 
canceling of queries. 
   
   ### TESTING INSTRUCTIONS
   
   Added unit tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to