graceguo-supercat opened a new pull request #15891: URL: https://github.com/apache/superset/pull/15891
### SUMMARY Fix an issue that SQL Lab didn't run correct sql after user pick a query from History. The root cause is that after update selected sql in redux store, it should also update component state. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Step to reproduce: 1. open sql lab 2. run a sql statement 3. pick a query from History tab 4. you will see SQL Editor updated with the picked query 5. Click Run button 6. The query result is not correct: query result is still from the previous sql statement.  ### TESTING INSTRUCTIONS CI and manual test. @jinghua-qa It's a little troublesome to add unit test for this bug. Could you add a test case for this flow? ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
