pkdotson commented on a change in pull request #15853:
URL: https://github.com/apache/superset/pull/15853#discussion_r677862049
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -79,32 +83,11 @@ interface ActivityProps {
loadedCount: number;
}
-const ActivityContainer = styled.div`
- margin-left: ${({ theme }) => theme.gridUnit * 2}px;
- margin-top: ${({ theme }) => theme.gridUnit * -4}px;
- display: grid;
- grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
-
- grid-gap: ${({ theme }) => theme.gridUnit * 8}px;
- justify-content: left;
- padding: ${({ theme }) => theme.gridUnit * 6}px;
- padding-top: ${({ theme }) => theme.gridUnit * 2}px;
- .ant-card-meta-avatar {
- margin-top: ${({ theme }) => theme.gridUnit * 3}px;
- margin-left: ${({ theme }) => theme.gridUnit * 2}px;
- color: ${({ theme }) => theme.colors.grayscale.base};
- }
- .ant-card-meta-title {
- font-weight: ${({ theme }) => theme.typography.weights.bold};
- }
- ${mq[3]} {
- grid-template-columns: repeat(auto-fit, minmax(31%, max-content));
- }
- ${mq[2]} {
- grid-template-columns: repeat(auto-fit, minmax(42%, max-content));
- }
- ${mq[1]} {
- grid-template-columns: repeat(auto-fit, minmax(80%, max-content));
+const Styles = styled.div`
+ .recentCards {
+ max-height: none;
+ grid-gap: ${({ theme }) =>
+ `${theme.gridUnit * 2.5}px ${theme.gridUnit * 5.5}px`};
Review comment:
This is so we can keep the same grid-gap as the other tables. The other
tables need a longer bottom gap so that they did not show inside of the
container on line wrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
