graceguo-supercat opened a new pull request #15995:
URL: https://github.com/apache/superset/pull/15995


   ### SUMMARY
   This PR add extra fix for #15891. After #15891, in airbnb some user found an 
issue when they open a new tab in sql lab. see #15992.
   
   I found when new query tab is added, which triggered redux store change, 
there is re-render for every existed query tabs, even if the tab is not the 
active tab. So when user click RUN in the new tab with new query, children 
component still had old tab's sql.
   
   ### TESTING INSTRUCTIONS
   CI and manual test.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #15891 #15992 
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @serenajiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to