conglei edited a comment on issue #5144: Adding a new viz line-bar chart
URL: 
https://github.com/apache/incubator-superset/pull/5144#issuecomment-444969390
 
 
   @VinodLouis  Thanks for adding this new visualization type to superset!
   
   As the community of superset is getting larger, we are aware of the 
increasing number of new visualization types added to Superset. It is great, 
however, it makes the visualization code hard to maintain and make the js 
bundle size larger. Due to this reason, the Superset community has proposed 
https://github.com/apache/incubator-superset/issues/5692, a js plugin system, 
to separate the visualization code from the superset core infra.  You can also 
check one example we are working on 
https://github.com/apache-superset/superset-ui/pull/50. It will be great if you 
can follow the same structure and help us to embrace the visualization plug-in 
system and any suggestion are welcome! 
   
   cc @SpyderRivera 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to