villebro commented on a change in pull request #16017:
URL: https://github.com/apache/superset/pull/16017#discussion_r680753218
##########
File path: superset/dashboards/commands/importers/v1/__init__.py
##########
@@ -96,7 +100,7 @@ def _import(
dataset = import_dataset(session, config, overwrite=False)
dataset_info[str(dataset.uuid)] = {
"datasource_id": dataset.id,
- "datasource_type": "view" if dataset.is_sqllab_view else
"table",
+ "datasource_type": dataset.datasource_type,
Review comment:
This also caused an import error, since virtual datasets are in fact
regular tables (they just have the `sql` property set).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
