john-bodley opened a new pull request #16029: URL: https://github.com/apache/superset/pull/16029
### SUMMARY Encoding time durations (timeout, wait, etc.) as `int` seems un-Pythonic in world of typing. Using `datetime.timedelta` seems clearer, i.e., `timedelta(hours=1)`. This PR merely seeds this mindset by replacing constructs like, ```python SCREENSHOT_LOAD_WAIT = 60 ``` with ```python SCREENSHOT_LOAD_WAIT = int(timedelta(minutes=1).total_seconds()) ``` whereas in the future it should simply be ```python SCREENSHOT_LOAD_WAIT: timedelta = timedelta(minutes=1) ``` where the code is updated to expect a `datetime.timedelta` object. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
