michael-s-molina opened a new pull request #16043:
URL: https://github.com/apache/superset/pull/16043


   ### SUMMARY
   Replaces the select for a dropdown button in the CSS editor. The dropdown 
button is more adequate to the current behavior where a user loads a template 
in the editor. In the previous version, the selection was not being preserved 
while interacting with the select and it shouldn't because the user is not 
editing the template but only copying its content to the editor. This was an 
indication that we were using the wrong component for the desired functionality.
   
   I also changed the editor border to use the theme colors and anchored the 
menu to the right to display CSS templates with big names.
   
   @junlincc @jinghua-qa @rusackas 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/128035410-bd3f3b5a-ed2d-4837-ac51-98e996084e1f.mov
   
   
https://user-images.githubusercontent.com/70410625/128035420-d837b8e4-76d1-49f3-86fb-f9bcc7d3b460.mov
   
   ### TESTING INSTRUCTIONS
   See the videos for instructions.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to