AAfghahi opened a new pull request #16118:
URL: https://github.com/apache/superset/pull/16118


   ### SUMMARY
   This PR adjusts who can see the new dashboard and chart subscribe Icon. 
Previously it was based on who can add a report, but now it is based on if you 
have access to alerts and reports in the settings menu. 
   
   While looking through this, I noticed that a limited/gamma user does have 
permissions to add, view, and has menu access to Alerts and Reports. Maybe this 
is an oversight and we need to adjust the permissions for Gamma users? 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Admin User: 
   ![Screen Shot 2021-08-06 at 11 27 15 
AM](https://user-images.githubusercontent.com/48933336/128534395-882a3b06-1483-47c9-890b-db6f42ec6ef5.png)
   Gamma: 
   ![Screen Shot 2021-08-06 at 11 27 57 
AM](https://user-images.githubusercontent.com/48933336/128534494-f57fdf8e-c9eb-42a0-87d8-4e6a6d32b907.png)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to