suddjian commented on a change in pull request #16094:
URL: https://github.com/apache/superset/pull/16094#discussion_r684352005
##########
File path: superset-frontend/src/dashboard/actions/hydrate.js
##########
@@ -366,7 +366,8 @@ export const hydrateDashboard = (dashboardData, chartData)
=> (
directPathLastUpdated: Date.now(),
focusedFilterField: null,
expandedSlices: metadata?.expanded_slices || {},
- refreshFrequency: metadata?.refresh_frequency || 0,
+ refreshFrequency:
+ metadata?.refresh_frequency || dashboardState.refreshFrequency || 0,
Review comment:
I'm not sure about the `|| dashboardState.refreshFrequency` here. If you
start at dashboard A (which has refresh), navigate to the dashboard list and
then go to dashboard B (which has no refresh) wouldn't B inherit the refresh
frequency from A?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
