villebro commented on a change in pull request #16139:
URL: https://github.com/apache/superset/pull/16139#discussion_r685095843
##########
File path: superset/utils/core.py
##########
@@ -189,6 +189,25 @@ class DatasourceDict(TypedDict):
id: int
+class AdhocFilterClause(TypedDict, total=False):
Review comment:
Since `TypedDict` doesn't support the notion of an optional property,
`total=False` is required here to be able to construct partial objects based on
this type. See
https://github.com/python/mypy/issues/2632#issuecomment-769549870 for more info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
