hughhhh commented on a change in pull request #16095:
URL: https://github.com/apache/superset/pull/16095#discussion_r685342781
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -834,6 +847,26 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
setTabKey(key);
};
+ const renderStepTwoAlert = () =>
+ db?.engine && (
+ <StyledAlertMargin>
+ <Alert
+ closable={false}
+ css={(theme: SupersetTheme) => antDAlertStyles(theme)}
+ type="info"
+ showIcon
+ message={
+ engineSpecificAlertMapping[db.engine]?.message ||
+ connectionAlert?.ALLOWED_IPS?.message
Review comment:
instead of naming it Allowed_IPS we should have a more general name.
Then users can set this value to whatever they'd like. Let's make the key
DEFAULT and then we'd update our superset config accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
