eschutho opened a new pull request #16158:
URL: https://github.com/apache/superset/pull/16158


   ### SUMMARY
   This brings in the code from 
https://github.com/apache/superset/pull/15984/commits/eeb69678346a093a1692f2e319f205fde7d03789
 that was lost in a feature branch merge. 
   
   It shows the same image/text options for charts on the report modal from 
charts that we show on the alerts/reports modals. 
   
   This also fixes a small bug where the dashboard needs to refetch reports on 
load. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
![image](https://user-images.githubusercontent.com/5186919/128788704-6bcde4ef-3bc9-4a9f-9cc5-800ce0b669fd.png)
   
   ### TESTING INSTRUCTIONS
   Create a chart with one of these options and ensure that the proper format 
was sent. Also the text options should only apply to tables.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to