geido opened a new pull request #16168: URL: https://github.com/apache/superset/pull/16168
### SUMMARY This PR fixes a problem with the visibility of the Omnibar dropdown. It also implements the ability to close the Omnibar by clicking ESC. Finally, it removes the ability to open the Omnibar with the _ctrl/cmd + s_ in order to stop it from interfering with the default browser functionality. The Omnibar can now be open with _ctrl/cmd + k_. Fixes: #15539 ### BEFORE https://user-images.githubusercontent.com/60598000/128879772-97e45c5e-84a9-4996-af59-b085d9e963cd.mp4 ### AFTER https://user-images.githubusercontent.com/60598000/128880027-1694f0cb-de87-461b-9542-e1f72722dd08.mp4 ### TESTING INSTRUCTIONS 1. Open a Dashboard 2. Press _cmd + k_ or _ctrl + k_ 3. Observe the Omnibar appearing and search for a Dashboard 4. Make sure that the matching Dashboards appear 5. Press ESC and make sure the Omnibar closes ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #15539 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
