kgabryje opened a new pull request #16190: URL: https://github.com/apache/superset/pull/16190
### SUMMARY When user added an adhoc metric, then opened a popover to edit that metric and clicked "Save" without doing any changes, the metric label would disappear. This PR adds a check if old and edited metric are equal - if they are, no actions are taken. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: see linked issue After: ### TESTING INSTRUCTIONS 0. Enable dnd 1. Create a chart and add an adhoc metric 2. Open a popover to edit that metric and click save without doing any changes 3. The metric label should stay as it was, no changes should happen ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes https://github.com/apache/superset/issues/16184 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @jinghua-qa @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
