geido opened a new pull request #16192:
URL: https://github.com/apache/superset/pull/16192


   ### SUMMARY
   This PR makes the tooltip appear only when the label does not fit the 
container in the Dataset panel. Also, it hides the tooltip when the drag event 
starts.
   
   ### BEFORE
   
   
https://user-images.githubusercontent.com/60598000/129005898-a3b9a073-355d-41d2-9627-fc77f1083238.mp4
   
   ### AFTER NO DRAG AND DROP
   
   
https://user-images.githubusercontent.com/60598000/129004634-224d4f17-8a2a-4c00-9376-0b70005b6f67.mp4
   
   ### AFTER DRAG AND DROP ON
   
   
https://user-images.githubusercontent.com/60598000/129004722-337326ca-d255-4203-ae7c-f95502067803.mp4
   
   ### TESTING INSTRUCTIONS
   1. Visit Explore
   2. Observe the labels with long text in the Dataset panel and make sure they 
are truncated with ellipsis
   3. Hover the labels and check the tooltip
   4. Expand the panel until the text isn't truncated and hover the labels
   5. Make sure the tooltip isn't appearing
   6. Drag an item
   7. Make sure the tooltip isn't appearing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #15996
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to