villebro opened a new pull request #16194: URL: https://github.com/apache/superset/pull/16194
### SUMMARY This is part 1 of a fix for #16067 to make the backend more resilient to incomplete chart metadata. If a adhoc metric is missing the `label` property, the backend can in most cases deduce what the label should be. Since the util `get_metric_name` is used in quite a few places in the backend and didn't have a single unit test, this PR also adds tests to ensure that the function works as expected. In addition, related types are improved and affected code updated. ### AFTER  ### BEFORE  ### TESTING INSTRUCTIONS 1. create an adhoc metric that either has a missing or empty label 2. make a chart data request 3. notice how the request fails ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
