michael-s-molina commented on issue #16173: URL: https://github.com/apache/superset/issues/16173#issuecomment-897100580
@ktmud @junlincc I tested a few scenarios: #### Only show the visualizations after selecting a dataset The screen appeared empty and we had a flicking effect. Even if the user selects a dataset, the button will still be greyed out and the user may not know why. It's because he also needs to select a viz type. #### Treat the screen as a form and validate the fields Validating the dataset field and the viz type (showing red borders) looked weird because this screen is not similar to a form but more like a selector. #### Applying @ktmud idea number 2 - Add a tooltip on the disabled "Create new chart" button directing users to select a dataset This one seems to be the best approach. At the same time, we can inform the user of BOTH required fields in a non-intrusive way. It also fits well with the design of the page. https://user-images.githubusercontent.com/70410625/129091423-1c241da2-89a7-43cd-89d1-96b07a62c139.mov > It won't be too empty if the datasets are rendered as tables similar to "Change datasets" modal on the Explore page. Currently, we are using the new select component to display the datasets. This gives us some nice features such as searching, lazy loading, and paginated fetch. Personally, I prefer the select over the table because it seems the more appropriate component for the type of selection that we are doing. What do you think? Can we agree on @ktmud idea number 2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
