junlincc edited a comment on pull request #16119:
URL: https://github.com/apache/superset/pull/16119#issuecomment-897119895
It depends on which direction we want to guide user to be on.
Here's my concern. With the + sign visual indication and the "Click or drop
a metric/column here" placeholder, I am almost 100% sure first time users will
click, instead of visit the left data panel first as their first interaction
with this popover.
Once user start on one path, and find it sufficient enough, it's very likely
they stick with the more familiar path and reluctant to try the other, which
may slowdown the adoption of dnd.
The fact that DND offers a much fast time to chart, compared to
click-to-select, I do want to intentionally guide user to start with this path,
and promote this path.
I prefer to keep it simple"Drop a metric/column here" as the "+" is a loud
enough call to action for clicking.
If we have to explicitly indicate again, "Click or drop a metric/column
here" makes more sense to me, definitely not to use "drag" in the wording.
Also, recently we do identify some sever regressions in the control panel
due to increasing complexity of the product by adding too many FF and having
multiple environments. I can't emphasize enough that maintaining both and
making sure both work well together and individually can be costly and messy.
I would push much harder keeping DND only and try to resolve all the
existing concerns, bottlenecks by improving this one solution if I am working
on a close source/design heavy product. However, Superset has its unique OSS
DNA which should be preserved and respected.
To whomever approve and support this hybrid solution, please do assess the
code, and test this PR throughout, and consider the risk, the complexity for
long term. @ktmud @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
