eschutho opened a new pull request #16214:
URL: https://github.com/apache/superset/pull/16214


   ### SUMMARY
   There are some errors on db connection ui when toggling on encryption, it 
would also get returned in the params field, and then would error when trying 
to turn off ssl with the toggle. 
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: 
   
https://user-images.githubusercontent.com/5186919/129117204-42cd6021-647d-4c33-a4d1-eff56130b63c.mov
   
   ### TESTING INSTRUCTIONS
   edit a database, and toggle on/off ssl
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to