john-bodley commented on a change in pull request #16146:
URL: https://github.com/apache/superset/pull/16146#discussion_r687381991
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1145,7 +1143,7 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
having_clause_and = []
for flt in filter: # type: ignore
- if not all([flt.get(s) for s in ["col", "op"]]):
+ if not all(flt.get(s) for s in ["col", "op"]):
Review comment:
I know many people find Pylint somewhat verbose and cumbersome, but the
linting rules and checks are far superior than other linters in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
