geido opened a new pull request #16232: URL: https://github.com/apache/superset/pull/16232
### SUMMARY This PR fixes an issue with the scrollbar in the Change Dataset modal that was scrolling too far at the bottom. Different from the ask in the related issue #15935, this PR does not stop the scrollbar from going over the sticky header. In order to stop the scrollbar from appearing over the sticky header, a complete refactor of the TableCollection component would be required. In fact, that behaviour is standard in the HTML tables when a sticky header is used. A full deviation from the standard HTML table would be required. For instance, the "Table" chart has a full custom implementation of the table in order to stop the scrollbar from going over the sticky header. ### BEFORE <img width="878" alt="Screen Shot 2021-07-28 at 10 41 38 AM" src="https://user-images.githubusercontent.com/67837651/127398200-713c6564-496b-4bbf-b82b-bcf05401ba26.png";> ### AFTER https://user-images.githubusercontent.com/60598000/129215292-6d07c6b7-f6d9-4c74-8133-90c45ac59a7f.mp4 ### TESTING INSTRUCTIONS 1. Open Explore 2. Click on "Change dataset" 3. Observe the table and scroll 4. Make sure the scrollbar does not appear down to the pagination ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #15935 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/67837651/127398200-713c6564-496b-4bbf-b82b-bcf05401ba26.png"](https://user-images.githubusercontent.com/67837651/127398200-713c6564-496b-4bbf-b82b-bcf05401ba26.png"){kind=link}