kgabryje opened a new pull request #16233: URL: https://github.com/apache/superset/pull/16233
### SUMMARY This PR fixes highlighting the chart emitting a cross filter when magnifier icon in filter's badge is clicked. Before, nothing happened when icon was clicked. Now it highlights and scrolls the chart to view and changes tab if needed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: see https://github.com/apache/superset/issues/16220 After: https://user-images.githubusercontent.com/15073128/129217878-f9c4547e-2763-4cc7-b423-cf801d3c4ae6.mov ### TESTING INSTRUCTIONS 0. Enable cross filtering feature flag 1. Open a dashboard that contains charts that can emit cross filters 2. Emit cross filter 3. Click filters badge on another chart and click magnifier icon of the chart that emits the cross filter 4. Verify that the source chart gets highlighted and scrolled into view ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes #16220 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @junlincc @jinghua-qa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
