michael-s-molina commented on pull request #16200: URL: https://github.com/apache/superset/pull/16200#issuecomment-897771192
@kgabryje @geido Thanks for the comments! > When I open the datasets select for the first time, I see a "No data" placeholder for about a second. Can we not show it? Or replace with some spinner? This is the default behavior of the Select component. We can try to change that but I would like to only change the Select's code after we write the tests for the component to avoid regressions at this point. It's a little tricky because of the sync and async modes. I'll add your suggestion to the component's list of improvements. > Also, when datasets description is very long (like World Bank Health Data from test datasets) has a very long description that doesn't fit in the tooltip. Can we show 3 dots at the end or something? Yes. Will do. > Can we replace \n\n with a span with some padding, so that we have more control over the spacings and can use grid unit from theme? Yes. Will do. > Why aren't we using the Antd Tooltip as everywhere else? I feel like this is harder to read. I was using the native feature of the Ant Design Select. To use our tooltip we need to change the component. I'll add your suggestion to the component's list of improvements. > I think we shouldn't be showing "No description" where there is no description available. The idea here was to show the user that he has the possibility to add a description. We'll add the info bubble in a follow-up PR according to @mistercrunch suggestions. I'm imagining that the icon will only appear for items that have a description so your concern will disappear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
